Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve delete conversation UX by swapping confirmation button positions #1546

Closed
flash1729 opened this issue Oct 28, 2024 · 2 comments · Fixed by #1547
Closed

Improve delete conversation UX by swapping confirmation button positions #1546

flash1729 opened this issue Oct 28, 2024 · 2 comments · Fixed by #1547
Assignees
Labels
enhancement New feature or request

Comments

@flash1729
Copy link
Contributor

Describe your feature request

Currently, when deleting a conversation, after clicking the delete (trash) icon, the confirm (checkmark) and cancel (cross) buttons appear in a position that requires moving the cursor away from the original click position to confirm deletion. This creates unnecessary mouse movement and reduces the user experience.

The proposal is to swap the positions of the confirm and cancel buttons so that the confirm button appears closer to where the delete icon was, making the deletion process more fluid and intuitive.

Screenshots (if relevant)

Before:
[Current behavior: Delete icon -> [Cross] [Checkmark]]
image

image

Implementation idea

The change requires modifying the NavConversationItem.svelte file to swap the order of the confirm and cancel buttons in the confirmation UI. The modification is simple and doesn't affect any underlying functionality.

I would like to implement this improvement myself. I've already identified the relevant code in src/lib/components/NavConversationItem.svelte.

Note: The current shift+click shortcut to bypass confirmation will be maintained.

@flash1729 flash1729 added the enhancement New feature or request label Oct 28, 2024
@nsarrazin
Copy link
Collaborator

Feel free to tackle this @flash1729! Thanks for tracking the issue

@flash1729
Copy link
Contributor Author

@nsarrazin I have applied the fix, please do review.

nsarrazin added a commit that referenced this issue Oct 28, 2024
Co-authored-by: Aditya Medhane <adityasmac@Adityas-MacBook-Air-3.local>
Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants