Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce message update size returned by websearch #1179

Merged
merged 5 commits into from
May 28, 2024

Conversation

nsarrazin
Copy link
Collaborator

The websearch was returning updates which contained a lot of information we don't use in the front-end.

This PR removes the data from the DB and remove the unnecessary data from websearch updates.

@nsarrazin nsarrazin added enhancement New feature or request websearch labels May 27, 2024
@nsarrazin nsarrazin requested review from mishig25 and Saghen May 27, 2024 10:47
@nsarrazin
Copy link
Collaborator Author

nsarrazin commented May 27, 2024

Since the front-end builds the websearch widget using the message updates, i don't think we need to be storing the full websearch object in the DB, wdyt ?

Copy link
Collaborator

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Copy link
Contributor

@Saghen Saghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one nit

@nsarrazin nsarrazin merged commit 606f76f into main May 28, 2024
3 checks passed
@nsarrazin nsarrazin deleted the refacto/reduce_update_size branch May 28, 2024 08:45
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* Reduce message update size returned by websearch

* lint

* Update src/lib/migrations/routines/06-trim-message-updates.ts

Co-authored-by: Liam Dyer <liamcdyer@gmail.com>

* clean up types

* clean up migrations

---------

Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request websearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants