-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce message update size returned by websearch #1179
Conversation
Since the front-end builds the websearch widget using the message updates, i don't think we need to be storing the full websearch object in the DB, wdyt ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one nit
Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
* Reduce message update size returned by websearch * lint * Update src/lib/migrations/routines/06-trim-message-updates.ts Co-authored-by: Liam Dyer <liamcdyer@gmail.com> * clean up types * clean up migrations --------- Co-authored-by: Liam Dyer <liamcdyer@gmail.com>
The websearch was returning updates which contained a lot of information we don't use in the front-end.
This PR removes the data from the DB and remove the unnecessary data from websearch updates.