Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic tool error msg "Error occurred" #1193

Merged
merged 2 commits into from
May 28, 2024
Merged

Generic tool error msg "Error occurred" #1193

merged 2 commits into from
May 28, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented May 28, 2024

slack context

follow up to #1168

When tool fails, a generic error msg "Error occurred" will be shown rather than the actual error msg for various reasons, including security concerns as it may reveal information that is not intended to the user. However, the actual error will still be logged for debugging (for admins)

@mishig25 mishig25 requested review from Saghen, gary149 and nsarrazin May 28, 2024 09:42
@mishig25 mishig25 merged commit 128b4c1 into main May 28, 2024
3 checks passed
@mishig25 mishig25 deleted the tool_generic_error branch May 28, 2024 09:47
@nsarrazin nsarrazin added the bug Something isn't working label May 28, 2024
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants