Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tools in endpointVertex now optional #1234

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix: tools in endpointVertex now optional #1234

merged 2 commits into from
May 31, 2024

Conversation

SebSchroen
Copy link
Contributor

@SebSchroen SebSchroen commented May 31, 2024

The googleSearchRetrieval leads to very odd and unnatural behavior when chatting with Gemini. Making the argument optional and removing it for certain use cases fixes the issue.

Behavior with googleSearchRetrieval:

Gemini_Pro_with_googleSearchRetrieval

The googleSearchRetrieval leads to very odd behavior when chatting with Gemini, making the argument optional and removing it for certain use cases fixes the issue
@nsarrazin nsarrazin merged commit 93b39a0 into huggingface:main May 31, 2024
3 checks passed
@nsarrazin
Copy link
Collaborator

Thanks for the contribution!

ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
The googleSearchRetrieval leads to very odd behavior when chatting with Gemini, making the argument optional and removing it for certain use cases fixes the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants