feat: allow custom message to guest users. #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
reviewed
Sep 9, 2024
samehkhattab
commented
Sep 10, 2024
|
@nsarrazin could you please take another look? |
nsarrazin
approved these changes
Sep 27, 2024
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* feat: allow custom guest message. * remove the messages_before_login condition. * fix: lint --------- Co-authored-by: Khattab, Sameh <sameh.khattab@uk-essen.de> Co-authored-by: Nathan Sarrazin <sarrazin.nathan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local installations, guest users currently see a default message from Hugging Face, which may be incorrect or irrelevant, especially if a custom OIDC mechanism is being used for authentication.
To address this, I added a new environment variable, PUBLIC_APP_GUEST_MESSAGE, which allows customization of the guest message. This variable depends on the existing MESSAGES_BEFORE_LOGIN setting.