Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add support for endpoint web sources #1544

Merged

Conversation

ArthurGoupil
Copy link
Contributor

@ArthurGoupil ArthurGoupil commented Oct 25, 2024

Some endpoints like VertexUI provides web sources used to generate the message.

This PR add the basis for any endpoint to add sources. They just have to provide webSource in the endpoint output.
Vertex implementation is done as an example.

Enregistrement.de.l.ecran.2024-10-25.a.12.51.38.yafw.balanced.mp4

@nsarrazin nsarrazin self-requested a review October 25, 2024 11:37
@nsarrazin nsarrazin self-assigned this Oct 25, 2024
Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Vertex endpoint is 🔥 thanks to you 😁

@nsarrazin nsarrazin merged commit 938e1d8 into huggingface:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants