Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assistnats] Fix pagination numTotalPages #780

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[Assistnats] Fix pagination numTotalPages #780

merged 3 commits into from
Feb 5, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Feb 5, 2024

numTotalPages should be reactive because sveltekit is making a partial reload rather than full reload.

Atm, there is this bug: only 3 items but the pagination is still visible

image

@mishig25 mishig25 requested review from gary149 and nsarrazin February 5, 2024 13:20
@mishig25 mishig25 marked this pull request as draft February 5, 2024 13:27
@mishig25 mishig25 marked this pull request as ready for review February 5, 2024 13:38
@mishig25 mishig25 merged commit 2468399 into main Feb 5, 2024
3 checks passed
@mishig25 mishig25 deleted the fix_pagination branch February 5, 2024 17:04
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* [Assistnats] Fix pagination numTotalPages

* morereactivity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants