Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assistnats] improve reporting #797

Merged
merged 6 commits into from
Feb 7, 2024
Merged

[Assistnats] improve reporting #797

merged 6 commits into from
Feb 7, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Feb 7, 2024

Post to webhook url "report assistant" events

Copy link
Collaborator

@nsarrazin nsarrazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me can't test the implem itself but code looks good! left a simple typo fix

EDIT: Tested locally with a test webhook and it works great

"Content-type": "application/json",
},
body: JSON.stringify({
text: `Assistant <${assistantUrl}|${assistant?.name}> reported by <http://hf.co/${locals.user?.username}|${locals.user?.username}>`,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mishig25 mishig25 merged commit e9f817c into main Feb 7, 2024
3 checks passed
@mishig25 mishig25 deleted the improve_reporting branch February 7, 2024 15:52
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
* [Assistnats] improve reporting

* typo

* make it more general

* typo

* update prodEnv script

* Update scripts/updateProdEnv.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants