Ask for a reason when reporting assistants #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
added
enhancement
mishig25
reviewed
Feb 15, 2024
| @@ -46,7 +46,7 @@ | |||
| role="presentation" | |||
| tabindex="-1" | |||
| bind:this={backdropEl} | |||
| on:click={handleBackdropClick} | |||
| on:click|stopPropagation={handleBackdropClick} | |||
There was a problem hiding this comment.
just to be sure, this doesn't affect other use cases of Modal. Right ?
There was a problem hiding this comment.
I tested our other modals and it doesn't, but I think we needed this line anyway: otherwise when you have two modals, clicking the backdrop would close all of them instead of the topmost one
mishig25
reviewed
Feb 15, 2024
mishig25
reviewed
Feb 15, 2024
src/routes/settings/assistants/[assistantId]/ReportModal.svelte
Outdated
Show resolved
Hide resolved
mishig25
reviewed
Feb 15, 2024
mishig25
reviewed
Feb 15, 2024
gary149
reviewed
Feb 15, 2024
src/routes/settings/assistants/[assistantId]/ReportModal.svelte
Outdated
Show resolved
Hide resolved
gary149
approved these changes
Feb 15, 2024
Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
|
Alright, going to check the slack integration in prod then! |
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* Show modal asking for assistant report reason * fix disabled button styling * parse with zod * Update src/routes/settings/assistants/[assistantId]/ReportModal.svelte Co-authored-by: Victor Muštar <victor.mustar@gmail.com> * use a text area with max-w --------- Co-authored-by: Victor Muštar <victor.mustar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maxed reason to 128 chars, should work with the slack webhook integration.