Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: done chapter 1-1.mdx issue #51 #101

Merged
merged 6 commits into from
May 6, 2022
Merged

Conversation

victorescosta
Copy link
Contributor

issue #51

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice translation @victorescosta 🥳 ! We just need to include this section in the _toctree.yml file, e.g. please add this:

- title: 1. Transformer models # <= Translate this
  sections:
  - local: chapter1/1
    title: Introduction # <= Translate this

@lewtun
Copy link
Member

lewtun commented Apr 20, 2022

Hey @victorescosta just checking if you'd like any help on adding the _toctree.yml file to this PR?

It's better to include it in this PR instead of #102 so we can test the website builds in the CI. Happy to help if you need it!

@victorescosta
Copy link
Contributor Author

Hey @victorescosta just checking if you'd like any help on adding the _toctree.yml file to this PR?

It's better to include it in this PR instead of #102 so we can test the website builds in the CI. Happy to help if you need it!

Hi @lewtun , i'm sorry i'm bit busy this week but in the weekend i'll do the changes, is it ok? I'm always open to be helped if it's needed or if we have a specific time to finish this task :)

@lewtun
Copy link
Member

lewtun commented Apr 21, 2022

Hi @lewtun , i'm sorry i'm bit busy this week but in the weekend i'll do the changes, is it ok? I'm always open to be helped if it's needed or if we have a specific time to finish this task :)

No rush, just wanted to check if you were stuck or not :) Looking forward to seeing the fix when you're ready!

@victorescosta
Copy link
Contributor Author

victorescosta commented May 1, 2022

All done, sir! @lewtun. Let's move on!
Actually, "some checks were not successful", @lewtun could you help me with this? I thought that everything was ok :/

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this @victorescosta! There's just a small fix needed in the table of contents, but otherwise this is looking great 🥳

chapters/pt/_toctree.yml Outdated Show resolved Hide resolved
victorescosta and others added 2 commits May 4, 2022 14:15
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 4, 2022

The documentation is not available anymore as the PR was closed or merged.

@victorescosta
Copy link
Contributor Author

Thank you so much for helping me @lewtun. I think that everything is ok now, right? 🕺

@lewtun
Copy link
Member

lewtun commented May 6, 2022

It looks great - thanks for the contribution!

Screen Shot 2022-05-06 at 12 33 20

@lewtun lewtun merged commit eb2d658 into huggingface:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants