-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: done chapter 1-1.mdx issue #51 #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this nice translation @victorescosta 🥳 ! We just need to include this section in the _toctree.yml
file, e.g. please add this:
- title: 1. Transformer models # <= Translate this
sections:
- local: chapter1/1
title: Introduction # <= Translate this
Hey @victorescosta just checking if you'd like any help on adding the It's better to include it in this PR instead of #102 so we can test the website builds in the CI. Happy to help if you need it! |
Hi @lewtun , i'm sorry i'm bit busy this week but in the weekend i'll do the changes, is it ok? I'm always open to be helped if it's needed or if we have a specific time to finish this task :) |
No rush, just wanted to check if you were stuck or not :) Looking forward to seeing the fix when you're ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this @victorescosta! There's just a small fix needed in the table of contents, but otherwise this is looking great 🥳
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
The documentation is not available anymore as the PR was closed or merged. |
Thank you so much for helping me @lewtun. I think that everything is ok now, right? 🕺 |
issue #51