-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Japanese chapter7 md1 and md2 second try. #246
add Japanese chapter7 md1 and md2 second try. #246
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great translation @webbigdata-jp !
Apart from a small change in the cross-linking it looks good to me 🔥
|
||
# イントロダクション | ||
|
||
[第3章](/course/chapter3)では、テキスト分類のためにモデルを微調整する方法を学びました。この章では、以下のような一般的な自然言語処理タスクに取り組みます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to put the language code here for the cross-link to work
[第3章](/course/chapter3)では、テキスト分類のためにモデルを微調整する方法を学びました。この章では、以下のような一般的な自然言語処理タスクに取り組みます。 | |
[第3章](/course/ja/chapter3)では、テキスト分類のためにモデルを微調整する方法を学びました。この章では、以下のような一般的な自然言語処理タスクに取り組みます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lewtun
Yay! That's my first PR approval!
Thanks for checking.
I will include the link fix in the next pull request.
Hi @webbigdata-jp there's a small merge conflict in the Would you mind fixing that or would you like me to help take care of it? |
@webbigdata-jp if I'm not mistaken, this PR is superceded by #267 right? If yes, feel free to close this PR :) |
@lewtun |
Hi @lewtun .
This is second try. I add Japanese chapter7/md1, 2.
I recreated the environment.
I also have done git add before make style.