Translated the whole chapter 4 into Thai #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Thank you for this incredible contribution @jomariya23156 - it's so cool to see a whole chapter translated in its entirety 🥳 !
I'll ask the Thai speakers for a quick review, but the structure of the files looks great to me
lewtun
reviewed
Apr 4, 2022
There was a problem hiding this comment.
FYI @jomariya23156 I just noticed two places where we need a comma in the quizzes - would you mind fixing them please? (I marked them in the PR)
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
|
@lewtun Thanks for letting me know! I have fixed them :) |
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have finished translating the whole chapter 4 into Thai. Please check it out and let me know if there is anything wrong. Cheers!
Related to #64