fix ogg audio

[AndreaFrancis]

Fix for #2045

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4238a17) 90.17% compared to head (65b3653) 87.45%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
- Coverage   90.17%   87.45%   -2.73%     
==========================================
  Files         262      118     -144     
  Lines       15945     4447   -11498     
==========================================
- Hits        14379     3889   -10490     
+ Misses       1566      558    -1008     

Flag	Coverage Δ
jobs_cache_maintenance	95.33% <ø> (ø)
jobs_mongodb_migration	86.69% <ø> (ø)
libs_libapi	?
libs_libcommon	?
services_admin	86.56% <ø> (ø)
services_api	87.09% <ø> (ø)
services_rows	85.49% <ø> (ø)
services_search	80.48% <ø> (ø)
services_sse-api	94.21% <ø> (ø)
services_worker	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[severo]

maybe add a test to ensure that ogg files were not working before, and are working now?

[AndreaFrancis]

maybe add a test to ensure that ogg files were not working before, and are working now?

I added a specific test. It was needed to mock s3 bucket since the issue only appears when using fsspec+s3fs.
Note that I had to do a couple of patches because of aiobotocore getmoto/moto#6836 and aio-libs/aiobotocore#755
MockRawResponse' object has no attribute 'raw_headers' error when using moto with s3fs

[severo]

wow, it was more complex than expected. Maybe another review before merging?

[AndreaFrancis]

wow, it was more complex than expected. Maybe another review before merging?

Sure.
I will fix the import error in libcommon unittests:

ImportError while importing test module '/home/runner/work/datasets-server/datasets-server/libs/libcommon/tests/viewer_utils/test_features.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/viewer_utils/test_features.py:12: in <module>
    import boto3
E   ModuleNotFoundError: No module named 'boto3'