Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete the dataset when repo is disabled or does not exist #2276

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

severo
Copy link
Collaborator

@severo severo commented Jan 11, 2024

Fixes #2272 and #2273.

See related PR: huggingface/huggingface_hub#1965 (once released, change the code in datasets-server)

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3ee12ad) 90.97% compared to head (661297a) 89.98%.

Files Patch % Lines
libs/libcommon/src/libcommon/operations.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
- Coverage   90.97%   89.98%   -1.00%     
==========================================
  Files         246      155      -91     
  Lines       14948     8775    -6173     
==========================================
- Hits        13599     7896    -5703     
+ Misses       1349      879     -470     
Flag Coverage Δ
jobs_cache_maintenance 95.17% <ø> (ø)
jobs_mongodb_migration 86.10% <ø> (ø)
libs_libcommon 92.48% <89.47%> (+0.09%) ⬆️
services_admin 87.92% <ø> (ø)
services_api 86.21% <ø> (ø)
services_rows 82.72% <ø> (ø)
services_search 80.57% <ø> (ø)
services_sse-api 94.19% <ø> (ø)
services_worker ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@severo severo merged commit 453aa6c into main Jan 11, 2024
22 checks passed
@severo severo deleted the delete-dataset-if-disabled-or-inexistent branch January 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the cache entries when a dataset does not exist anymore
4 participants