Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dictionary features to croissant dataset definitions. #3102

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ccl-core
Copy link
Contributor

No description provided.

@ccl-core ccl-core changed the title [Not yet ready for review] Include dictionary features to crs Include dictionary features to croissant dataset definitions. Nov 13, 2024
@ccl-core ccl-core marked this pull request as ready for review November 13, 2024 08:46
@ccl-core
Copy link
Contributor Author

Hi @lhoestq ! Here a PR to include dictionary features in the croissant definitions generated from HF infos. When you have time, can you PTAL? 😊

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good ! can you fix the failing test in the worker ci before we merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants