Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fsspec 2023.10.0 #6333

Closed
albertvillanova opened this issue Oct 23, 2023 · 4 comments · Fixed by #6334 or #6336
Closed

Support fsspec 2023.10.0 #6333

albertvillanova opened this issue Oct 23, 2023 · 4 comments · Fixed by #6334 or #6336
Assignees
@albertvillanova

Comments

@albertvillanova
Copy link
Member

albertvillanova commented Oct 23, 2023 •
edited
Loading

Once root issue is fixed, remove temporary pin of fsspec < 2023.10.0 introduced by:

Related to issue:

As @ZachNagengast suggested, the issue might be related to:
@albertvillanova albertvillanova self-assigned this Oct 23, 2023
@albertvillanova albertvillanova mentioned this issue Oct 23, 2023
Closed
@chejennifer chejennifer mentioned this issue Oct 24, 2023
Merged
chejennifer added a commit to datacommonsorg/website that referenced this issue Oct 24, 2023
@chejennifer
Fix Test Failures (#3715)
ea4090a 
- the nl server uses the package `datasets` which uses the package
`fsspec`. The most recent version of `fsspec` causes problems with
`datasets` as mentioned here:
huggingface/datasets#6333
@Jiyong-Jeon Jiyong-Jeon mentioned this issue Oct 25, 2023
Merged
beets pushed a commit to beets/website that referenced this issue Nov 6, 2023
@chejennifer @beets
Fix Test Failures (datacommonsorg#3715)
562fd0a 
- the nl server uses the package `datasets` which uses the package
`fsspec`. The most recent version of `fsspec` causes problems with
`datasets` as mentioned here:
huggingface/datasets#6333
acolver pushed a commit to GPS-Demos/datacommons-website that referenced this issue Jan 8, 2024
@chejennifer @acolver
Fix Test Failures (datacommonsorg#3715)
409e3fd 
- the nl server uses the package `datasets` which uses the package
`fsspec`. The most recent version of `fsspec` causes problems with
`datasets` as mentioned here:
huggingface/datasets#6333
@tomscholz
Copy link

tomscholz commented Feb 7, 2024 •
edited
Loading

Hi @albertvillanova @lhoestq

I believe the pull request that pins the fsspec version (#6331) was merged by mistake. Another fix for the issue was merged on the same day an hour apart. See #6334

I'm now having an issue in my project where I can't use newer versions of fsspec.

Can we remove the pin?

Have a nice day! :)

@albertvillanova
Copy link
Member Author

albertvillanova commented Feb 7, 2024 •
edited
Loading

Hi @tomscholz,

Thanks for pointing this out. I think you are right.

I am doing some cross-checks and fixing it.

@albertvillanova
Copy link
Member Author

albertvillanova commented Feb 7, 2024 •
edited
Loading

Hi again, @tomscholz.

After a more cautious investigation, I think the pin is OK because there are other reasons for it. Chronologically:

The reason is that after version 2023.10.0, they changed again the behavior of their glob function. See: #6337 (comment)
We are working on our side to support both previous and new glob behavior.

Note:

  • First pin was < 2023.10.0
  • Last pin is <= 2023.10.0

@albertvillanova
Copy link
Member Author

Fixed by #6334 and #6336.

This was referenced Feb 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertvillanova albertvillanova

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@albertvillanova @tomscholz