Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Drive URL to avoid Virus scan warning #3787

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Feb 25, 2022

This PR fixes, in the datasets library instead of in every specific dataset, the issue of downloading the Virus scan warning page instead of the actual data file for Google Drive URLs.

Fix #3786, fix #3784.

@AngadSethi
Copy link

Thanks for this @albertvillanova!

@albertvillanova
Copy link
Member Author

Once this PR merged into master and until our next datasets library release, you can get this fix by installing our library from the GitHub master branch:

pip install git+https://github.com/huggingface/datasets#egg=datasets

Then, if you had previously tried to load the data and got the checksum error, you should force the redownload of the data (before the fix, you just downloaded and cached the virus scan warning page, instead of the data file):

load_dataset("...", download_mode="force_redownload")

@tscholak
Copy link

tscholak commented Mar 4, 2022

Thanks, that solved a bunch of problems we had downstream!
cf. ServiceNow/picard#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug downloading Virus scan warning page from Google Drive URLs Unable to Download CNN-Dailymail Dataset
3 participants