Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patching module that doesn't exist #4495

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Jun 15, 2022

Reported in https://github.com/huggingface/huggingface_hub/runs/6894703718?check_suite_focus=true

When trying to patch scipy.io.loadmat:

ModuleNotFoundError: No module named 'scipy'

Instead it shouldn't raise an error and do nothing

Bug introduced by #4375

Fix #4494

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 15, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq merged commit 60b8df4 into master Jun 15, 2022
@lhoestq lhoestq deleted the fix-patching-module-that-doesnt-exist branch June 15, 2022 08:54
khushmeeet pushed a commit to khushmeeet/datasets that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patching fails for modules that are not installed or don't exist
2 participants