Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming] retry on requests errors #6963

Merged
merged 3 commits into from
Jun 28, 2024
Merged

[Streaming] retry on requests errors #6963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9c8655
[Streaming] retry on requests errors
lhoestq Jun 10, 2024
3e05f34
Merge branch 'main' into stream-etry-on-requests-errors
lhoestq Jun 28, 2024
6cd13c1
lucain's comment
lhoestq Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/datasets/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
Copyright by the AllenNLP authors.
"""

import asyncio
import copy
import glob
import io
Expand All @@ -20,7 +21,6 @@
import warnings
import xml.dom.minidom
import zipfile
from asyncio import TimeoutError
from contextlib import closing, contextmanager
from functools import partial
from io import BytesIO
Expand All @@ -31,10 +31,10 @@
from urllib.parse import urljoin, urlparse
from xml.etree import ElementTree as ET

import aiohttp.client_exceptions
import fsspec
import huggingface_hub
import requests
from aiohttp.client_exceptions import ClientError
from fsspec.core import strip_protocol, url_to_fs
from fsspec.utils import can_be_local
from huggingface_hub.utils import EntryNotFoundError, insecure_hashlib
Expand Down Expand Up @@ -1093,7 +1093,12 @@ def read_with_retries(*args, **kwargs):
try:
out = read(*args, **kwargs)
break
except (ClientError, TimeoutError) as err:
except (
aiohttp.client_exceptions.ClientError,
asyncio.TimeoutError,
requests.exceptions.ConnectTimeout,
requests.exceptions.ConnectionError,
) as err:
disconnect_err = err
logger.warning(
f"Got disconnected from remote data host. Retrying in {config.STREAMING_READ_RETRY_INTERVAL}sec [{retry}/{max_retries}]"
Expand Down
Loading