-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify add_column() to optionally accept a FeatureType as param #7143
Modify add_column() to optionally accept a FeatureType as param #7143
Conversation
Requesting review @lhoestq |
Cool ! maybe you can rename the argument |
b6b3aa0
to
383a18e
Compare
@lhoestq Since there is no way to get a |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Can you just add the feature
argument to the docstrings before we merge ?
@lhoestq done! |
@lhoestq anything pending on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! LGTM :)
Fix #7142.
Before (Add + Cast):
Before (Numpy Workaround):
After: