-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Karras Sigmas to all schedulers #2905
Comments
Seems fun. Currently working on the LoRA tests PR but I'd like to take a crack at this if it's not urgent. |
Seems like a requested feature. I will try to allocate some time next week. @patrickvonplaten, anything you have in mind regarding the design I should know? I think we should consider separate PRs for separate schedulers to help with the reviews and also to keep the PRs disentangled. @pie31415 thanks so much for being willing to help! We deeply appreciate it. Let's see how we want to tackle this and based on that we can circle back :) |
Looking forward to it! |
Regarding design I think it'll be all about changing the sigmas here correctly:
In my opinion some kind of helper function that we can easily copy-paste to other schedulels like: if use_karras_sigmas:
sigmas = self.convert_to_karras(sigmas) would make sense |
#2956 could be a good reference PR to add |
Related PR: #3001 |
I think we have added support for Karras sigmas for all the most popular schedulers now. So, I think it's okay to close this issue. |
Is your feature request related to a problem? Please describe.
As stated in multiple issue:
Describe the solution you'd like
It would be nice to be able to do:
and
Describe alternatives you've considered
No alternative possible
Additional context
We have a nice PR: #2874 that solves this for the Karras stable diffusion pipeline, but it would be nice to have this for all native diffusion schedulers as well.
#2874 can be very nicely used for integration testing.
Also cc @sayakpaul @takuma104
The text was updated successfully, but these errors were encountered: