-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Q] Possibly unused self.final_alpha_cumprod
#9395
Comments
self.final_alpha_cumprod
self.final_alpha_cumprod
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Commenting to remove "stale" label. I think this should be addressed as it may highlight a mismatch on what |
thanks for the issue! and sorry that I missed this earlier |
Thank you, no worries only commented to remove the automatic labeling. I am not sure on the issue though. Is the solution replacing |
I think the condition is just to make sure we are at the final step, so maybe |
As far as I understand at the final step, |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Hello team, quick question to make sure I understand the behavior of the
step
function in LCM Scheduler.diffusers/src/diffusers/schedulers/scheduling_lcm.py
Lines 534 to 543 in a7361dc
Here, it seems that the condition
prev_timestep >= 0
is alwaysTrue
, becausetimestep
andself.timesteps[prev_step_index]
cannot be negative. This would mean thatself.final_alpha_cumprod
is never used. Is there a way in whichprev_timestep
can be negative?The text was updated successfully, but these errors were encountered: