Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Bug in FluxPosEmbed #10115

Merged
merged 7 commits into from
Dec 5, 2024
Merged

[FIX] Bug in FluxPosEmbed #10115

merged 7 commits into from
Dec 5, 2024

Conversation

SahilCarterr
Copy link
Contributor

What does this PR do?

Fix get_1d_rotary_pos_embed in embedding.py

Fixes #10111

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed.
@yiyixuxu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu requested a review from hlky December 4, 2024 19:48
Copy link
Member

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@hlky hlky merged commit 3335e22 into huggingface:main Dec 5, 2024
15 checks passed
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Fix get_1d_rotary_pos_embed in embedding.py

* Update embeddings.py

---------

Co-authored-by: hlky <hlky@hlky.ac>
@SahilCarterr SahilCarterr deleted the flux_emb branch February 5, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some bugs in FLUX pipeline
3 participants