Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix num images per prompt unclip #1787

Merged
merged 6 commits into from
Dec 20, 2022
Merged

Fix num images per prompt unclip #1787

merged 6 commits into from
Dec 20, 2022

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Dec 20, 2022 •
edited
Loading

Use repeat_interleave instead of repeat to duplicate the attention masks.
fixes #1785

This PR also adpats the test envs to use released accelerate version rather than main, as test_from_save_pretrained_dtype tests are faling with accelerate main as a result of huggingface/accelerate#920

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 20, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patil-suraj patil-suraj requested a review from pcuenca December 20, 2022 14:14
anton-l
anton-l approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! One more line to remove is ${CONDA_RUN} python -m pip install git+https://github.com/huggingface/accelerate in the standalone MPS tests

pcuenca
pcuenca approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@patil-suraj patil-suraj merged commit d07f730 into main Dec 20, 2022
@patil-suraj patil-suraj deleted the fix-num_images_per_prompt-unclip branch December 20, 2022 15:03
anton-l pushed a commit that referenced this pull request Dec 20, 2022
@patil-suraj @pcuenca @anton-l
Fix num images per prompt unclip (#1787)
40b0519 
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
@patil-suraj @pcuenca @sliard
Fix num images per prompt unclip (huggingface#1787)
781a2a0 
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patil-suraj @pcuenca
Fix num images per prompt unclip (huggingface#1787)
0fbf016 
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

@pcuenca pcuenca pcuenca approved these changes

@patrickvonplaten patrickvonplaten Awaiting requested review from patrickvonplaten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

num_images_per_prompt > 1 still broken with UnCLIPPipeline
4 participants
@patil-suraj @HuggingFaceDocBuilderDev @pcuenca @anton-l