Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable Diffusion Guide] 101 Stable Diffusion Guide directly into the docs #1927

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

patrickvonplaten
Copy link
Contributor

This adds the long overdue SD diffusion guide right into the docs.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 5, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks a lot!

docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved

We're at roughly 3.5 seconds per image 🔥 which is probably the fastest we can be with a simple T4 without sacrificing quality.

Next, let's look into how to improve the quality!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention xformers, even if we don't use it in the notebook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned it in the very end :-)

docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
docs/source/en/conceptual/stable_diffusion.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great guide on stable diffusion. Loved it!

one question: why it is the "conceptual guide" section? what is this section intended for?

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@patrickvonplaten
Copy link
Contributor Author

great guide on stable diffusion. Loved it!

one question: why it is the "conceptual guide" section? what is this section intended for?

That's a very good question! I'll actually put it instead in the getting started section as the "conceptual section" is indeed no the right fit.

@patrickvonplaten patrickvonplaten merged commit 2533f92 into main Jan 5, 2023
@patrickvonplaten patrickvonplaten deleted the add_sd_101 branch January 5, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants