Remove modelcards dependency #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -87,10 +83,11 @@ def get_full_repo_name(model_id: str, organization: Optional[str] = None, token: | |||
|
|
|||
|
|
|||
| def create_model_card(args, model_name): | |||
| if not is_modelcards_available: | |||
| if not is_jinja_available(): | |||
| @@ -21,6 +21,7 @@ | |||
| from collections import OrderedDict | |||
| from typing import Union | |||
|
|
|||
| from huggingface_hub.utils import is_jinja_available # noqa: F401 | |||
There was a problem hiding this comment.
Just to be sure this is supported since huggingface_hub 0.10 ? That's currently our minimum required version for the Hub.
There was a problem hiding this comment.
Ah yeah you answered that above
patrickvonplaten
approved these changes
Jan 20, 2023
|
That was a quick review! 😄 Thanks |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Switch to huggingface_hub.ModelCard * Remove modelcards dependency in favor of Jinja2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2047, I realized that
diffusersdepends onmodelcardspackage which is deprecated and not maintained anymore. This PR switches to thehuggingface_hubimplementation -a copy ofmodelcardswith a few fixes-. It has been integrated tohfhin version0.10which is already a requirement fordiffusers.To make it work, one must have
Jinja2installed which was already a requirement. I've updated thecreate_model_cardhelper and wrote a test for it. Actually I'm not sure it was working at all as the template path seemed to be wrong.(this PR also removed
is_modelcards_availableboolean method. Idk the deprecation policy indiffusersbut I can put it back if needed. I have added ais_jinja_available(fromhuggingface_hub.utils) which is more appropriate now.Note: this is not related to the
0.12release ofhuggingface_hub. It can be merged before or after it doesn't matter (or never)