Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] add dataloader_num_workers argument #2070

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

patil-suraj
Copy link
Contributor

This PR adds the --dataloader_num_workers argument to training scripts to let user choose the number of workers for dataloaders. In dreambooth script, this value was hardcoded to 1, which breaks the script on windows, so changing it back to the torch default of 0.

Fixes #2041

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 23, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pcuenca
Copy link
Member

pcuenca commented Jan 23, 2023

Could this be the reason why some people experience poor performance on multi-GPU setups?

@patil-suraj
Copy link
Contributor Author

Could this be the reason why some people experience poor performance on multi-GPU setups?

@pcuenca it's possible, but not 100% sure.

@patil-suraj patil-suraj merged commit 6fedb29 into main Jan 23, 2023
@patil-suraj patil-suraj deleted the dl-workers branch January 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dreambooth example is not compatible with Windows
4 participants