Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dreambooth] fix multi on gpu. #2088

Merged
merged 1 commit into from
Jan 24, 2023
Merged

[dreambooth] fix multi on gpu. #2088

merged 1 commit into from
Jan 24, 2023

Conversation

patil-suraj
Copy link
Contributor

@patil-suraj patil-suraj commented Jan 24, 2023 •
edited
Loading

When using multi GPU, the model becomes an instance of DistributedDataParallel, and we need to unwrap the model to access any property/methods of the model. This PR unwraps the model before accessing dtype arg.
cc @williamberman

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 24, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pcuenca
pcuenca approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing!

patrickvonplaten
patrickvonplaten approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good point! Thanks for fixing.

@patil-suraj patil-suraj merged commit fc8afa3 into main Jan 24, 2023
@patil-suraj patil-suraj deleted the fix-dreambooth-multi-gpu branch January 24, 2023 12:24
@patil-suraj patil-suraj mentioned this pull request Jan 24, 2023
Closed
@chjose
Copy link

chjose commented Jan 24, 2023

Thanks for fixing this!

@patrickvonplaten patrickvonplaten mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@pcuenca pcuenca pcuenca approved these changes

@williamberman williamberman Awaiting requested review from williamberman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patil-suraj @HuggingFaceDocBuilderDev @chjose @pcuenca @patrickvonplaten