Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEFT] Fix peft ci #5185

Closed
wants to merge 2 commits into from
Closed

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Fixes the current PEFT LoRA CI - we also need: huggingface/transformers#26407 to be merged

With huggingface/peft#905 being merged, the logic for manipulating the active adapter(s) has changed a bit. Now, active_adapter is a property method and returns a list, in order to deal with multiple adapter inference.

This PR adjusts the current PEFT integration by properly dealing with the case module.active_adapter returns a list, therefore fixing the multiple adapter case

cc @BenjaminBossan @pacman100 @patrickvonplaten @sayakpaul

@sayakpaul
Copy link
Member

Thank you! Can merge once the CI is green.

@patrickvonplaten
Copy link
Contributor

Merged main into PR to fix flaky test

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada
Copy link
Contributor Author

Thanks ! Let's merge it after huggingface/transformers#26407 being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants