Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wuerstchen] dreambooth lora #6247

Closed
wants to merge 16 commits into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Dec 20, 2023

What does this PR do?

Lora dreambooth training scripts for Wuerstchen prior pipeline.

Example: https://wandb.ai/krasul/dreambooth-lora/runs/7ia16ohd

needs #6046

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to go for me, but I'm really not sure if it's that important. We haven't seen much usage of Wuerstchen yet and I'm not sure if anyone is training LoRAs on it

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 26, 2024
@github-actions github-actions bot closed this Feb 4, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Feb 4, 2024
@yiyixuxu yiyixuxu reopened this Feb 4, 2024
@yiyixuxu yiyixuxu requested a review from sayakpaul February 4, 2024 22:18
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Feb 4, 2024

cc @sayakpaul here -
can you take a look to see if we can merge this?

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Does it also make sense to incorporate the changes to prevent #6552?

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Feb 5, 2024

@sayakpaul
yeah for sure -
do you want to add to your list? feel free to merge this PR if you think it's ready:)

@sayakpaul
Copy link
Member

Sorry, I was asking @kashif about incorporating the changes.

@kashif
Copy link
Contributor Author

kashif commented Feb 5, 2024

Ah yes @sayakpaul let me have a look... shouldn't be hard

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 2, 2024
@sayakpaul
Copy link
Member

I guess this is NOT stale? @kashif

@github-actions github-actions bot removed the stale Issues that haven't received updates label Mar 3, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 27, 2024
@yiyixuxu
Copy link
Collaborator

pin @kashif

@yiyixuxu
Copy link
Collaborator

@sayakpaul
I'm also ok with merging it in and opening up this to the community to help fix if @kashif does not have time

@github-actions github-actions bot removed the stale Issues that haven't received updates label Mar 28, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 21, 2024
@DN6
Copy link
Collaborator

DN6 commented Apr 22, 2024

Should this be opened up to community then? cc: @sayakpaul @kashif?

@kashif
Copy link
Contributor Author

kashif commented Apr 22, 2024

yes sure!

@github-actions github-actions bot removed the stale Issues that haven't received updates label Apr 22, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label May 16, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label May 20, 2024
@yiyixuxu
Copy link
Collaborator

cc @sayakpaul can we merge this and open the remaining task for the community?

@sayakpaul
Copy link
Member

@kashif let's maybe move this to examples/research_projects? I will go ahead and merge then.

@kashif
Copy link
Contributor Author

kashif commented May 21, 2024

ok

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@ParagEkbote
Copy link
Contributor

Hi, can I please move the required files to examples/research_projects?

Maybe that could close this pending PR?

cc: @sayakpaul

@sayakpaul
Copy link
Member

Sure, that works for me. Cc: @kashif

@ParagEkbote
Copy link
Contributor

I have opened a PR with the requested changes.

Could you please review?

cc: @sayakpaul

@github-actions github-actions bot removed the stale Issues that haven't received updates label Nov 15, 2024
@ParagEkbote
Copy link
Contributor

Thank you for @kashif for allowing me to lead the PR to its completion.

Could we please close this PR as #9935 has been merged.

cc: @sayakpaul

@sayakpaul sayakpaul closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants