Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update: tutorials ja | INDEX.md, TUTORIAL_OVERVIEW.md, TOCTREE.yml #6338

Merged
merged 15 commits into from
Jan 8, 2024

Conversation

YasunaCoffee
Copy link
Contributor

@YasunaCoffee YasunaCoffee commented Dec 26, 2023

What does this PR do?

Changes included in this pull request

Related to #6309

What is this PR about ?

I translated the following files to implified Japanese:

  • _toctree.yml
  • index.md
  • docs/ja/tutorials/tutorial_overview.md

What should you check ?

Grammar and orthograph
If my pull requests follows GitHub/open source contribution good practices (I am a beginner)

Before submitting

Who can review?

Docs: @stevhliu and @yiyixuxu

@YasunaCoffee YasunaCoffee changed the title Transtate ja [Docs][WIP] update: tutorials ja Dec 26, 2023
@YasunaCoffee
Copy link
Contributor Author

YasunaCoffee commented Dec 26, 2023

Hi, there!
I have only completed the translation of the OVERVIEW of the TUTORIALS, please confirm the content if this is correct.

Docs: @stevhliu and @yiyixuxu

@YasunaCoffee YasunaCoffee marked this pull request as ready for review December 27, 2023 04:17
@stevhliu
Copy link
Member

stevhliu commented Jan 3, 2024

Thanks for starting the tutorial translations! The structure of tutorial_overview.md looks correct to me, but as I'm not a Japanese speaker, I can't say for the content itself 😅 . Do you know other people in the Japanese-speaking community who would be interested in reviewing your work?

@YasunaCoffee
Copy link
Contributor Author

@stevhliu
Thanks for your comment!

Do you know other people in the Japanese-speaking community who would be interested in reviewing your work?

I'm gonna try to find a Japanese friends interested in reviewing diffusers docs!
Please wait a minute :)

@Prgckwb
Copy link
Contributor

Prgckwb commented Jan 6, 2024

Hello everyone! I'm a native Japanese speaker and I'm interested in the diffusers Japanese translation project. Is there anything I can do to help?

@YasunaCoffee
Copy link
Contributor Author

@Prgckwb cc @stevhliu
Thank you for your efforts for translating!
We're really excited to contribute with you 🤗

First things first,
Could you review the following files?

_toctree.yml
docs/ja/tutorials/tutorial_overview.md

What should you check ?

Grammar and orthograph
If my pull requests follows GitHub/open source contribution good practices (I am a beginner)

@YasunaCoffee
Copy link
Contributor Author

@Prgckwb
You can also start a new translation from this issue! ありがとうございます!
#6309

Copy link
Contributor

@Prgckwb Prgckwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice translation! 🥳

I don't know if the revised review is correct here, but I looked through the files that seem to have been translated all the way through. (Sorry if this is in the wrong place 😢)

title: AutoPipeline
- local: tutorials/basic_training
title: diffusionモデルのトレーニング
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to unify "diffusion", which is not a proper noun or class name, with "拡散モデル".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you and fix it, thanks!
20b3508

@@ -18,7 +18,7 @@ specific language governing permissions and limitations under the License.

# Diffusers

🤗 Diffusers は、画像や音声、さらには分子の3D構造を生成するための、最先端の事前学習済みDiffusion Model(拡散モデル)を提供するライブラリです。シンプルな生成ソリューションをお探しの場合でも、独自の拡散モデルをトレーニングしたい場合でも、🤗 Diffusers はその両方をサポートするモジュール式のツールボックスです。我々のライブラリは、[性能より使いやすさ](conceptual/philosophy#usability-over-performance)、[簡単よりシンプル](conceptual/philosophy#simple-over-easy)、[抽象化よりカスタマイズ性](conceptual/philosophy#tweakable-contributorfriendly-over-abstraction)に重点を置いて設計されています。
🤗 Diffusers は、画像や音声、さらには分子の3D構造を生成するための、最先端の事前学習済みDiffusion Model(拡散モデル)を提供するライブラリです。シンプルな生成ソリューションをお探しの場合でも、独自の拡散モデルをトレーニングしたい場合でも、🤗 Diffusers はその両方をサポートするモジュール式のツールボックスです。私たちのライブラリは、[性能より使いやすさ](conceptual/philosophy#usability-over-performance)、[簡単よりシンプル](conceptual/philosophy#simple-over-easy)、[抽象化よりカスタマイズ性](conceptual/philosophy#tweakable-contributorfriendly-over-abstraction)に重点を置いて設計されています。

このライブラリには3つの主要コンポーネントがあります:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the following bullet points introduce the major components, the body form seems appropriate :)

First bullet point.
I think the expression "数行のコードで推論可能な最先端の拡散パイプライン" is better than the expression "最先端の拡散パイプラインで数行のコードで生成が可能です".

Furthermore, if we stick to the original, the translation of "There are many pipelines ... the task they solve" seems to be missing.

Second bullet point.
"生成速度と品質に対するトレードオフのバランスを取る交換可能なノイズスケジューラ" would be good.

Third bullet point.
"ビルディングブロックとして使用することができ、スケジューラと組み合わせることでエンドツーエンドの拡散モデルを構築可能な事前学習済みモデル" would be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I agree with all of your reviews and then fix them, thanks!
04f0516

@@ -30,7 +30,7 @@ specific language governing permissions and limitations under the License.
<div class="w-full flex flex-col space-y-4 md:space-y-0 md:grid md:grid-cols-2 md:gap-y-4 md:gap-x-5">
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./tutorials/tutorial_overview"
><div class="w-full text-center bg-gradient-to-br from-blue-400 to-blue-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">チュートリアル</div>
<p class="text-gray-700">出力の生成、独自の拡散システムの構築、拡散モデルのトレーニングを開始するために必要な基本的なスキルを学ぶことができます。初めて🤗Diffusersを使用する場合は、ここから始めることをお勧めします!</p>
<p class="text-gray-700">出力の生成、独自の拡散システムの構築、拡散モデルのトレーニングを開始するために必要な基本的なスキルを学ぶことができます。初めて🤗Diffusersを使用する場合は、ここから始めることをおすすめします!</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a detail, but it would be easier to see if there is a half-width space between English words and Japanese words! 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks!
c9484ac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
Sorry, I fix it again ;)
547e87d

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 37, "ロード" can be "読み込み".
Line 44, "Reference" could be "リファレンス" (I think it is fine as it is in English) 👍
The "Supported pipeline" clause below line 55 does not appear to be included in the original English index.md. (My apologies if I am mistaken) 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks!
bef8d90


# Overview

ようこそ🧨Diffusersへ!拡散モデル(diffusion models)や生成AIの初心者で、さらに学びたいのであれば、このチュートリアルが最適です。この初心者向けのチュートリアルは、拡散モデルについて丁寧に解説し、ライブラリの基礎(核となるコンポーネントと🧨Diffusersの使用方法)を理解することを目的としています。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be easier to read if there is a half-width space between English words and Japanese words 👀

ex) "ようこそ🧨Diffusersへ!" -> "ようこそ 🧨Diffusers へ!"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks!
8a5fa6c


ようこそ🧨Diffusersへ!拡散モデル(diffusion models)や生成AIの初心者で、さらに学びたいのであれば、このチュートリアルが最適です。この初心者向けのチュートリアルは、拡散モデルについて丁寧に解説し、ライブラリの基礎(核となるコンポーネントと🧨Diffusersの使用方法)を理解することを目的としています。

まず、推論のためのパイプラインを使って、素早く生成する方法を学んでいきます。次に、パイプラインの仕組みを理解するために、拡散システムを構築するための機能のライブラリの使い方を理解します。次の章では、あなたが作りたいものを生成するために、拡散モデルをトレーニングする方法を学びます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"次に、独自の拡散システムを構築するためのモジュラーツールボックスとしてライブラリをどのように使えば良いかを理解するために、そのパイプラインを分解してみましょう。次のレッスンでは、あなたの欲しいものを生成できるように拡散モデルをトレーニングする方法を学びましょう。" would be better. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks!
8a5fa6c


まず、推論のためのパイプラインを使って、素早く生成する方法を学んでいきます。次に、パイプラインの仕組みを理解するために、拡散システムを構築するための機能のライブラリの使い方を理解します。次の章では、あなたが作りたいものを生成するために、拡散モデルをトレーニングする方法を学びます。

このチュートリアルがすべて完了しらた、ライブラリを自分で調べ、自分のプロジェクトやアプリケーションにどのように使えるかを知るために必要なスキルを身につけることができます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完了しらた -> 完了したら

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks😁
8a5fa6c


そして、 [Discord](https://discord.com/invite/JfAtkvEtRb) や [forums](https://discuss.huggingface.co/c/discussion-related-to-httpsgithubcomhuggingfacediffusers/63) でDiffusersコミュニティに参加してユーザーや開発者と繋がって協力していきましょう。

さあ、🧨Diffusersをはじめていきましょう!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the word of "diffusing" is used in the original, I think "さあ、「拡散」をはじめていきましょう!🧨" is better? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prgckwb
I fix it, thanks!
8a5fa6c

@YasunaCoffee
Copy link
Contributor Author

@Prgckwb
Thanks for all of your effort for this review🤗
If all fixes should be fine, please ping the huggingface reviewer @stevhliu and write your comment like "lgtm".

Copy link
Contributor

@Prgckwb Prgckwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick and excellent fix! 😁

There seems to be a typo in one part, please fix that. 😢

Other than that, I think we're good to go.

</a>
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./conceptual/philosophy"
><div class="w-full text-center bg-gradient-to-br from-pink-400 to-pink-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">Conceptual guides</div>
<p class="text-gray-700">ライブラリがなぜこのように設計されたのかを理解し、ライブラリを利用する際の倫理的ガイドラインや安全対策について詳しく学べます。</p>
</a>
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./api/models/overview"
><div class="w-full text-center bg-gradient-to-br from-purple-400 to-purple-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">Reference</div>
><div class="w-full text-center bg-gradient-to-br from-purple-400 to-purple-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">リファレス</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リファレス -> リファレンス

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fb! It's all done!

@YasunaCoffee
Copy link
Contributor Author

YasunaCoffee commented Jan 8, 2024

Hi, @stevhliu!
We complitely reviewed with @Prgckwb this pull request.
Please check above whether It's seems to be good or not🙏

@YasunaCoffee YasunaCoffee changed the title [Docs][WIP] update: tutorials ja [Docs] update: tutorials ja | INDEX.md, TUTORIAL_OVERVIEW.md, TOCTREE.yml Jan 8, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for your interest and help in translating the Japanese docs @Prgckwb! 🤗

LGTM, great job everyone! 🎉

@stevhliu stevhliu merged commit 6ae7e81 into huggingface:main Jan 8, 2024
14 checks passed
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
….yml (huggingface#6338)

* add tutorials to toctree.yml

* fix title

* fix words

* add overview ja

* fix diffusion to 拡散

* fix line 21

* add space

* delete supported pipline

* fix tutorial_overview.md

* fix space

* fix typo

* Delete docs/source/ja/tutorials/using_peft_for_inference.md

this file is not translated

* Delete docs/source/ja/tutorials/basic_training.md

this file is not translated

* Delete docs/source/ja/tutorials/autopipeline.md

this file is not translated

* fix toctree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants