-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] update: tutorials ja | INDEX.md, TUTORIAL_OVERVIEW.md, TOCTREE.yml #6338
Conversation
Thanks for starting the tutorial translations! The structure of |
@stevhliu
I'm gonna try to find a Japanese friends interested in reviewing diffusers docs! |
Hello everyone! I'm a native Japanese speaker and I'm interested in the diffusers Japanese translation project. Is there anything I can do to help? |
@Prgckwb cc @stevhliu First things first,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice translation! 🥳
I don't know if the revised review is correct here, but I looked through the files that seem to have been translated all the way through. (Sorry if this is in the wrong place 😢)
docs/source/ja/_toctree.yml
Outdated
title: AutoPipeline | ||
- local: tutorials/basic_training | ||
title: diffusionモデルのトレーニング |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to unify "diffusion", which is not a proper noun or class name, with "拡散モデル".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you and fix it, thanks!
20b3508
@@ -18,7 +18,7 @@ specific language governing permissions and limitations under the License. | |||
|
|||
# Diffusers | |||
|
|||
🤗 Diffusers は、画像や音声、さらには分子の3D構造を生成するための、最先端の事前学習済みDiffusion Model(拡散モデル)を提供するライブラリです。シンプルな生成ソリューションをお探しの場合でも、独自の拡散モデルをトレーニングしたい場合でも、🤗 Diffusers はその両方をサポートするモジュール式のツールボックスです。我々のライブラリは、[性能より使いやすさ](conceptual/philosophy#usability-over-performance)、[簡単よりシンプル](conceptual/philosophy#simple-over-easy)、[抽象化よりカスタマイズ性](conceptual/philosophy#tweakable-contributorfriendly-over-abstraction)に重点を置いて設計されています。 | |||
🤗 Diffusers は、画像や音声、さらには分子の3D構造を生成するための、最先端の事前学習済みDiffusion Model(拡散モデル)を提供するライブラリです。シンプルな生成ソリューションをお探しの場合でも、独自の拡散モデルをトレーニングしたい場合でも、🤗 Diffusers はその両方をサポートするモジュール式のツールボックスです。私たちのライブラリは、[性能より使いやすさ](conceptual/philosophy#usability-over-performance)、[簡単よりシンプル](conceptual/philosophy#simple-over-easy)、[抽象化よりカスタマイズ性](conceptual/philosophy#tweakable-contributorfriendly-over-abstraction)に重点を置いて設計されています。 | |||
|
|||
このライブラリには3つの主要コンポーネントがあります: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the following bullet points introduce the major components, the body form seems appropriate :)
First bullet point.
I think the expression "数行のコードで推論可能な最先端の拡散パイプライン" is better than the expression "最先端の拡散パイプラインで数行のコードで生成が可能です".
Furthermore, if we stick to the original, the translation of "There are many pipelines ... the task they solve" seems to be missing.
Second bullet point.
"生成速度と品質に対するトレードオフのバランスを取る交換可能なノイズスケジューラ" would be good.
Third bullet point.
"ビルディングブロックとして使用することができ、スケジューラと組み合わせることでエンドツーエンドの拡散モデルを構築可能な事前学習済みモデル" would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/source/ja/index.md
Outdated
@@ -30,7 +30,7 @@ specific language governing permissions and limitations under the License. | |||
<div class="w-full flex flex-col space-y-4 md:space-y-0 md:grid md:grid-cols-2 md:gap-y-4 md:gap-x-5"> | |||
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./tutorials/tutorial_overview" | |||
><div class="w-full text-center bg-gradient-to-br from-blue-400 to-blue-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">チュートリアル</div> | |||
<p class="text-gray-700">出力の生成、独自の拡散システムの構築、拡散モデルのトレーニングを開始するために必要な基本的なスキルを学ぶことができます。初めて🤗Diffusersを使用する場合は、ここから始めることをお勧めします!</p> | |||
<p class="text-gray-700">出力の生成、独自の拡散システムの構築、拡散モデルのトレーニングを開始するために必要な基本的なスキルを学ぶことができます。初めて🤗Diffusersを使用する場合は、ここから始めることをおすすめします!</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a detail, but it would be easier to see if there is a half-width space between English words and Japanese words! 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 37, "ロード" can be "読み込み".
Line 44, "Reference" could be "リファレンス" (I think it is fine as it is in English) 👍
The "Supported pipeline" clause below line 55 does not appear to be included in the original English index.md. (My apologies if I am mistaken) 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# Overview | ||
|
||
ようこそ🧨Diffusersへ!拡散モデル(diffusion models)や生成AIの初心者で、さらに学びたいのであれば、このチュートリアルが最適です。この初心者向けのチュートリアルは、拡散モデルについて丁寧に解説し、ライブラリの基礎(核となるコンポーネントと🧨Diffusersの使用方法)を理解することを目的としています。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be easier to read if there is a half-width space between English words and Japanese words 👀
ex) "ようこそ🧨Diffusersへ!" -> "ようこそ 🧨Diffusers へ!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
ようこそ🧨Diffusersへ!拡散モデル(diffusion models)や生成AIの初心者で、さらに学びたいのであれば、このチュートリアルが最適です。この初心者向けのチュートリアルは、拡散モデルについて丁寧に解説し、ライブラリの基礎(核となるコンポーネントと🧨Diffusersの使用方法)を理解することを目的としています。 | ||
|
||
まず、推論のためのパイプラインを使って、素早く生成する方法を学んでいきます。次に、パイプラインの仕組みを理解するために、拡散システムを構築するための機能のライブラリの使い方を理解します。次の章では、あなたが作りたいものを生成するために、拡散モデルをトレーニングする方法を学びます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"次に、独自の拡散システムを構築するためのモジュラーツールボックスとしてライブラリをどのように使えば良いかを理解するために、そのパイプラインを分解してみましょう。次のレッスンでは、あなたの欲しいものを生成できるように拡散モデルをトレーニングする方法を学びましょう。" would be better. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
まず、推論のためのパイプラインを使って、素早く生成する方法を学んでいきます。次に、パイプラインの仕組みを理解するために、拡散システムを構築するための機能のライブラリの使い方を理解します。次の章では、あなたが作りたいものを生成するために、拡散モデルをトレーニングする方法を学びます。 | ||
|
||
このチュートリアルがすべて完了しらた、ライブラリを自分で調べ、自分のプロジェクトやアプリケーションにどのように使えるかを知るために必要なスキルを身につけることができます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
完了しらた -> 完了したら
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
そして、 [Discord](https://discord.com/invite/JfAtkvEtRb) や [forums](https://discuss.huggingface.co/c/discussion-related-to-httpsgithubcomhuggingfacediffusers/63) でDiffusersコミュニティに参加してユーザーや開発者と繋がって協力していきましょう。 | ||
|
||
さあ、🧨Diffusersをはじめていきましょう! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the word of "diffusing" is used in the original, I think "さあ、「拡散」をはじめていきましょう!🧨" is better? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prgckwb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick and excellent fix! 😁
There seems to be a typo in one part, please fix that. 😢
Other than that, I think we're good to go.
docs/source/ja/index.md
Outdated
</a> | ||
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./conceptual/philosophy" | ||
><div class="w-full text-center bg-gradient-to-br from-pink-400 to-pink-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">Conceptual guides</div> | ||
<p class="text-gray-700">ライブラリがなぜこのように設計されたのかを理解し、ライブラリを利用する際の倫理的ガイドラインや安全対策について詳しく学べます。</p> | ||
</a> | ||
<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./api/models/overview" | ||
><div class="w-full text-center bg-gradient-to-br from-purple-400 to-purple-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">Reference</div> | ||
><div class="w-full text-center bg-gradient-to-br from-purple-400 to-purple-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">リファレス</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リファレス -> リファレンス
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fb! It's all done!
this file is not translated
this file is not translated
this file is not translated
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thanks for your interest and help in translating the Japanese docs @Prgckwb! 🤗
LGTM, great job everyone! 🎉
….yml (huggingface#6338) * add tutorials to toctree.yml * fix title * fix words * add overview ja * fix diffusion to 拡散 * fix line 21 * add space * delete supported pipline * fix tutorial_overview.md * fix space * fix typo * Delete docs/source/ja/tutorials/using_peft_for_inference.md this file is not translated * Delete docs/source/ja/tutorials/basic_training.md this file is not translated * Delete docs/source/ja/tutorials/autopipeline.md this file is not translated * fix toctree
What does this PR do?
Changes included in this pull request
Related to #6309
What is this PR about ?
I translated the following files to implified Japanese:
What should you check ?
Grammar and orthograph
If my pull requests follows GitHub/open source contribution good practices (I am a beginner)
Before submitting
Error with Doc-Builder: Error 404 on Section Pages in Doc-Builder Preview
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Docs: @stevhliu and @yiyixuxu