Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline mode import #6467

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix offline mode import #6467

merged 1 commit into from
Jan 5, 2024

Conversation

Wauplin
Copy link
Collaborator

@Wauplin Wauplin commented Jan 5, 2024

Follow-up PR after #6456 (cc @sayakpaul).

In #6456, I added support for offline mode. However I forgot to update huggingface_hub version in the dependencies as highlighted by @voytez in #6456 (comment).

This PR fixes this by making huggingface_hub>=0.20.2 the minimal version. This shouldn't cause any problem as diffusers is already compatible with 0.20.2 and I'm not aware of any library pinning huggingface_hub<0.20.

(for the record, setting HF_HUB_OFFLINE=1 doesn't raise an error when calling model_info(...) on versions <0.20.x)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Wauplin Wauplin merged commit 9a9daee into main Jan 5, 2024
16 checks passed
@Wauplin Wauplin mentioned this pull request Jan 17, 2024
@sayakpaul sayakpaul deleted the fix-offline-mode-import branch January 17, 2024 14:36
patrickvonplaten pushed a commit that referenced this pull request Jan 17, 2024
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants