-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug of flip in SDXL training script #6547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed simplifies the cognitive load, thank you! It would be nice if we could create a little notebook to explain these conditions better to the community (not needed in this PR, this is me just blaberring).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
* Update train_text_to_image_sdxl.py * Update train_text_to_image_lora_sdxl.py
What does this PR do?
Fixes a problem mentioned in #4632 (comment). For now, the crop condition is problematic because of the flip operation.
First, the following lines should be changed from
to
Then, to avoid confusion about the coordinates order, it is elegant to conduct flip before crop.