Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed requests.get() function call by adding timeout parameter #7742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Apr 22, 2024

What does this PR do?

Fixed requests.get() function call by adding 10 seconds timeout.
Fixes #7730

Before submitting

Who can review?

@DN6 @sayakpaul

@Sai-Suraj-27 Sai-Suraj-27 changed the title fix: Fixed requests.get() function call by adding timeout parameter fix: Fixed requests.get() function call by adding timeout parameter Apr 22, 2024
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Apr 22, 2024

cc @DN6 here for a review

@DN6
Copy link
Collaborator

DN6 commented Apr 24, 2024

Don't think the timeout should be hardcoded. I think it's better to define a constant e.g DIFFUSERS_REQUEST_TIMEOUT that you should be able to override via environment variable and then pass that to the requests timeout. That way you can change the timeout based on your network.

Also, I think we can set a default to 60s (downloading images can take time on slow connections)

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@a-r-r-o-w
Copy link
Member

Gentle ping @Sai-Suraj-27 to address @DN6's review. This will also close #7730

@github-actions github-actions bot removed the stale Issues that haven't received updates label Nov 20, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of requests call without timeout parameter
4 participants