-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Fix Copying Mechanism typo/bug #8232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there were a couple of # copied from ... that weren't capitalized.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for merging! |
* Fix copying mechanism typos * fix copying mecha * Revert, since they are in TODO * Fix copying mechanism
What does this PR do?
"# copied from ..."s don't trigger the Copying Mechanism; thus they are capitalized. Also, decorators need to be at the top of "# Copied from ..."s.
The
_convert_to_karrasfunction inscheduling_dpmsolver_sde.pyandscheduling_lms_discrete.pyalso has this typo (?). But, it is included in a TODO task in the comments where they copied from, thus leaving them as are.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul @yiyixuxu @DN6