Skip to content

Conversation

@tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented May 22, 2024

What does this PR do?

"# copied from ..."s don't trigger the Copying Mechanism; thus they are capitalized. Also, decorators need to be at the top of "# Copied from ..."s.

The _convert_to_karras function in scheduling_dpmsolver_sde.py and scheduling_lms_discrete.py also has this typo (?). But, it is included in a TODO task in the comments where they copied from, thus leaving them as are.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul @yiyixuxu @DN6

@tolgacangoz tolgacangoz changed the title Fix copying mechanism typos Fix copying mechanism typo/bug May 22, 2024
@tolgacangoz tolgacangoz changed the title Fix copying mechanism typo/bug Fix Copying Mechanism typo/bug May 22, 2024
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu requested a review from stevhliu May 28, 2024 21:43
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there were a couple of # copied from ... that weren't capitalized.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tolgacangoz tolgacangoz requested review from stevhliu and yiyixuxu May 29, 2024 08:00
@stevhliu stevhliu merged commit a2ecce2 into huggingface:main May 29, 2024
@tolgacangoz
Copy link
Contributor Author

Thanks for merging!

@tolgacangoz tolgacangoz deleted the fix-copying-mechanism branch May 29, 2024 16:41
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Fix copying mechanism typos

* fix copying mecha

* Revert, since they are in TODO

* Fix copying mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants