Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from cached_download #8419

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Conversation

Wauplin
Copy link
Collaborator

@Wauplin Wauplin commented Jun 6, 2024

Follow-up PR after #8417.

In #8417, we introduce a mirror of the community pipeline modules as a HF dataset. This means we can now download modules from HF using hf_hub_download directly.

@Wauplin Wauplin requested a review from sayakpaul June 6, 2024 16:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This design looks good to me!

@Wauplin Wauplin marked this pull request as ready for review June 7, 2024 09:48
@Wauplin Wauplin requested a review from sayakpaul June 7, 2024 09:48
@Wauplin
Copy link
Collaborator Author

Wauplin commented Jun 7, 2024

@sayakpaul I've addressed your comment + added a custom error to ask to open an issue if a revision is not correctly pushed. Hopefully it'll be fine for 99.9% of users using main or a tag. Let me know what you think.

@sayakpaul sayakpaul merged commit 0d68ddf into main Jun 7, 2024
17 checks passed
@sayakpaul
Copy link
Member

Killer work here!

@sayakpaul sayakpaul deleted the move-away-from-cached_download branch June 7, 2024 10:13
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Move away from

* unused constant

* Add custom error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants