-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Permission for GH token in stale.yml #9427
Merged
sayakpaul
merged 5 commits into
huggingface:main
from
BenjaminBossan:mnt-permission-github-token-stale-bot
Sep 13, 2024
Merged
MAINT Permission for GH token in stale.yml #9427
sayakpaul
merged 5 commits into
huggingface:main
from
BenjaminBossan:mnt-permission-github-token-stale-bot
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See huggingface/peft#2061 for the equivalent PR in PEFT. This restores the functionality of the stale bot after permissions for the token have been limited. The action still shows errors for PEFT but the bot appears to work fine.
Ping @sayakpaul @yiyixuxu. See internal discussion. Not sure why CI fails, I don't think it's related. |
I added permissions for PRs too. |
@sayakpaul I think this can be merged. The same change restored the stale bot's functionality for PEFT. |
sayakpaul
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
* MAINT Permission for GH token in stale.yml See huggingface/peft#2061 for the equivalent PR in PEFT. This restores the functionality of the stale bot after permissions for the token have been limited. The action still shows errors for PEFT but the bot appears to work fine. * Also add write permissions for PRs --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See huggingface/peft#2061 for the equivalent PR in PEFT.
The stale bot is currently failing. This restores the functionality of the stale bot after permissions for the token have been limited. The action still shows errors for PEFT but the bot appears to work fine.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.