Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Permission for GH token in stale.yml #9427

Conversation

BenjaminBossan
Copy link
Member

What does this PR do?

See huggingface/peft#2061 for the equivalent PR in PEFT.

The stale bot is currently failing. This restores the functionality of the stale bot after permissions for the token have been limited. The action still shows errors for PEFT but the bot appears to work fine.

Before submitting

See huggingface/peft#2061 for the equivalent PR
in PEFT.

This restores the functionality of the stale bot after permissions for
the token have been limited. The action still shows errors for PEFT but
the bot appears to work fine.
@BenjaminBossan
Copy link
Member Author

Ping @sayakpaul @yiyixuxu. See internal discussion. Not sure why CI fails, I don't think it's related.

@sayakpaul
Copy link
Member

#9426

@BenjaminBossan
Copy link
Member Author

I added permissions for PRs too.

@BenjaminBossan
Copy link
Member Author

@sayakpaul I think this can be merged. The same change restored the stale bot's functionality for PEFT.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sayakpaul sayakpaul merged commit 48e3635 into huggingface:main Sep 13, 2024
7 checks passed
leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
* MAINT Permission for GH token in stale.yml

See huggingface/peft#2061 for the equivalent PR
in PEFT.

This restores the functionality of the stale bot after permissions for
the token have been limited. The action still shows errors for PEFT but
the bot appears to work fine.

* Also add write permissions for PRs

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants