Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deps_table_update to fix CI tests #9720

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

a-r-r-o-w
Copy link
Member

What does this PR do?

We missed this step (I did not know we had to do it) in #9709. Also contains a dummy change for now to trigger CI fast tests

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul @DN6

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w
Copy link
Member Author

@sayakpaul, seems like capping the torch version in diffusers to <2.5.0 does not fix the failing tests, because 2.5 gets installed by peft (see here).

@sayakpaul
Copy link
Member

I am not sure if that is the case because from the logs of that action, I don't see any reinstallations of PyTorch, though.

To confirm things, I would try print the PyTorch version just after the container is initialized. After this line:

python -m uv pip install -e [quality,test]

If it's 2.5.0, then there's something wrong.

@sayakpaul
Copy link
Member

sayakpaul commented Oct 20, 2024

Hmm I am pretty sure that the updated Torch is coming from

So, we need to:

  • Pin torch versions in the Dockerfiles
  • Verify Dockerfiles build
  • Trigger a Docker build and push workflow

Just pinning in the setup.py file won't cut it and my bad it went unnoticed.

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul merged commit 24281f8 into main Oct 21, 2024
18 checks passed
@sayakpaul sayakpaul deleted the fix-dependecy-versions branch October 21, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants