Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks for Community Scripts Examples #9905

Merged

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Nov 11, 2024

What does this PR do?

I've added 3 new Jupyter notebooks for IP Adapter Negative Noise, Asymmetric Tiling and Prompting Scheduling Callback. Additionally, I have improved the Prompting Scheduling Callback Script by a tiny bit. Are any more required changes?

Please let me know, and I will make the necessary changes as required.

Before submitting

Who can review?

Core library:

@sayakpaul
Copy link
Member

Thanks for your work but I think the notebooks should go to: https://github.com/huggingface/notebooks

Cc: @stevhliu

@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Nov 11, 2024

@sayakpaul I have created the 3 notebooks in this repository because I believe there is scope mentioned for them here: https://github.com/huggingface/diffusers/blob/main/examples/community/README_community_scripts.md

Also, if I wanted to contribute notebooks to additional community examples mentioned below, where can I add them:
https://github.com/huggingface/diffusers/blob/main/examples/community/README.md

Could you please let me know?

@stevhliu
Copy link
Member

Yeah I think it'd be best to keep the notebooks in https://github.com/huggingface/notebooks and add a link in the Colab column for them from there (likewise for the additional community notebook examples).

@ParagEkbote
Copy link
Contributor Author

I'll add the notebooks on the mentioned repo and update the branch accordingly.

cc: @stevhliu

@ParagEkbote
Copy link
Contributor Author

I have updated the ReadMe as per the given feedback.

Could you please review?

cc: @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks again for your contribution!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ParagEkbote
Copy link
Contributor Author

I have updated the ReadMe as per the given feedback.

Could you please review?

cc: @sayakpaul

@yiyixuxu yiyixuxu merged commit 1dbd26f into huggingface:main Nov 13, 2024
1 check passed
@yiyixuxu
Copy link
Collaborator

thanks very much for your contribution! @ParagEkbote

@ParagEkbote ParagEkbote deleted the Colab-notebooks-community-scripts branch November 13, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants