Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repo_owner input to build workflows #302

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Add repo_owner input to build workflows #302

merged 1 commit into from
Sep 27, 2022

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Sep 26, 2022

Resolves #300. Any thoughts on "required: true" vs "required: false" would be nice here :).

mishig25
mishig25 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mishig25 mishig25 merged commit 6b1fd8b into main Sep 27, 2022
@mishig25 mishig25 deleted the add-repo-owner-to-build-workflows branch September 27, 2022 07:56
mishig25 pushed a commit that referenced this pull request Sep 27, 2022
Revert ":sparkles: Add repo_owner input to build workflows (#302)"
81191d2 
This reverts commit 6b1fd8b.
@mishig25 mishig25 mentioned this pull request Sep 27, 2022
Merged
mishig25 added a commit that referenced this pull request Sep 27, 2022
@mishig25
Revert ":sparkles: Add repo_owner input to build workflows (#302)" (#303
b7699a3 
)

This reverts commit 6b1fd8b.
@mishig25 mishig25 restored the add-repo-owner-to-build-workflows branch September 27, 2022 07:57
@mishig25
Copy link
Contributor

@nateraw thanks a lot for this change!

after some testing, I had to turn remove required: True so that it repo_owner falssback to huggingface default value when non-provided.
Successfully tested a doc-build here & merged here

@nateraw
Copy link
Contributor Author

nateraw commented Sep 27, 2022

Thank you, sir!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishig25 mishig25 mishig25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to build from repos under different org/user
2 participants
@nateraw @mishig25