-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <include>
block for including non-code files
#370
Conversation
Not too sure what the "canonical test" is used for (defined in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like for @mishig25 to also have a look since he is the one who wrote that part of the code :-)
Sounds good 👍 I did run the tests on my side, and it worked correctly there. Perhaps I am using an outdated version of Edit: Yep, wasn't using the correct version. Getting the same result now. Will fix. |
Was including the last newline (when this should be removed with .`rstrip()`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work !
Allow markdown files to include other (non-code) files. Useful to ensure minimal duplication across files.
I added a few test cases (copy-pasted and edited from
literalinclude
)