Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SvelteKit migration] to latest Sveltekit version #396

Merged
merged 10 commits into from
Sep 24, 2023
Merged

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Sep 6, 2023

TLDR: Migrate to latest SvelteKit

The previous SvelteKit that was used in doc-builder was an pre-1.0 release one. There has been a lot of changes on SvelteKit, including new routing mechanism. Overall, it is a good time to migrate to the latest sveltekit and keep doc-builder up-to-date

Not sure if there will be any performance gains in building doc html files. If so, that would be nice.

todos:

  • remove unnecessary dev files
  • python copying mdx files should put them in new sveltekit 1.0 [slug]/page.svelte format bfcaa45
  • test it intensively locally (tested it on datasets docs)
  • check objects.inv file location being correct
  • test it on transformers docs (make sure paths in translated pages are working as expected) [wip testing doc-builder] transformers#26027 link to workflow
    • pushed doc file here
    • newly built doc files causing 500 internal server error (fix this error) (fixed b0bbce4)
  • title not changing (page should reload on click) (handled in hub pr)
  • left side menu not changing (handled in hub pr)
  • fix failing test (fixed transformersd dep bf1b146)
  • revert dev doc build action changes

mishig25 added a commit to huggingface/transformers that referenced this pull request Sep 7, 2023
@mishig25 mishig25 marked this pull request as ready for review September 17, 2023 20:21
@mishig25 mishig25 merged commit 7a6ced2 into main Sep 24, 2023
4 checks passed
@mishig25 mishig25 deleted the migrate_svelte_kit branch September 24, 2023 17:38
@coyotte508
Copy link
Member

Wow 🤯 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants