Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR docs message] Update saying available for 30 days #463

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Dec 5, 2023

Update the PR docs comment bot message saying that the PR docs are available until {today+30 days}. After 30 days, delete_old_pr_documentations.yml deletes the PR doc artifacts automatically.

@LysandreJik
Copy link
Member

Will the docs be automatically removed 30 days after the PR is opened or 30 days after the last update?

The former means that if a PR stays open for longer than 30 days, we'll remove the docs before it has been merged (longest PR on transformers was maybe ~6-7 months). If the latter then I'm not sure the comment will be updated

@mishig25
Copy link
Contributor Author

mishig25 commented Dec 5, 2023

Will the docs be automatically removed 30 days after the PR is opened or 30 days after the last update?

could you comment on it @coyotte508

@coyotte508
Copy link
Member

30 days after lst update. And they will be recreated if needed (eg after a 30 day pause)

@LysandreJik
Copy link
Member

Perfect! So let's maybe juste update the message to say "30 days after the last update" @mishig25 ?

@mishig25 mishig25 merged commit bc09a53 into main Dec 5, 2023
4 checks passed
@mishig25 mishig25 deleted the update_pr_docs_message branch December 5, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants