Skip to content

Conversation

@burtenshaw
Copy link
Contributor

This package has lost parity with transformers and datasets, so this PR drops the integrations tests.

@burtenshaw burtenshaw requested a review from Vaibhavs10 August 11, 2025 08:20
@burtenshaw burtenshaw mentioned this pull request Aug 11, 2025
@burtenshaw burtenshaw requested review from NathanHB and lhoestq August 11, 2025 08:21
@lhoestq
Copy link
Member

lhoestq commented Aug 11, 2025

What do you mean "lost parity" ? The issue is just the dataset used in the test suite is not supported by datasets anymore, we can just update it - I'll open a PR

@burtenshaw
Copy link
Contributor Author

What do you mean "lost parity" ? The issue is just the dataset used in the test suite is not supported by datasets anymore, we can just update it - I'll open a PR

Sorry. Weird choice of words. I just meant that evaluate isn't actively maintained so failing the parity/integration could be expected.

@lhoestq
Copy link
Member

lhoestq commented Aug 11, 2025

closing in favor of #696

@lhoestq lhoestq closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants