Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc build] Use secrets #37

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[doc build] Use secrets #37

merged 1 commit into from
Jun 12, 2023

Conversation

mishig25
Copy link
Contributor

@mishig25 mishig25 commented Jun 9, 2023

Companion pr to huggingface/doc-builder#379
Please feel free to merge it yourself

@mishig25 mishig25 requested a review from philschmid June 9, 2023 08:40
philschmid
philschmid approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add secrets to the repo or have you already done that?

@mishig25
Copy link
Contributor Author

it is already done through org-level secrets 👍

@mishig25 mishig25 merged commit 343a86a into main Jun 12, 2023
@mishig25 mishig25 deleted the docbuild-secrets branch June 12, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschmid philschmid philschmid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishig25 @philschmid