Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing the lib slightly. #52

Merged
merged 15 commits into from
Dec 26, 2024
Merged

Refreshing the lib slightly. #52

merged 15 commits into from
Dec 26, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Dec 23, 2024

No description provided.

Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, ty!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use thiserror as well, code would be a bit leaner but I'm ok with it as is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoiding adding a dependency for this overly simple one. Definitely let's add it if it every becomes much more verbose.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Narsil Narsil merged commit edb4239 into main Dec 26, 2024
16 checks passed
@McPatate McPatate deleted the refresher branch February 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants