Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about truncation when listing collections #1146

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Nov 29, 2023

Related to slack thread (internal).

GET /api/collections do not return complete objects. Collections are truncated to keep only 4 items for performance reasons. This PR adds a warning in the api.md documentation.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Wauplin
Copy link
Contributor Author

Wauplin commented Nov 29, 2023

Thanks for the quick review :)

@Wauplin Wauplin merged commit 10f097e into main Nov 29, 2023
1 check passed
@Wauplin Wauplin deleted the warn-about-collection-truncation branch November 29, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants