-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDUF documentation #1526
base: main
Are you sure you want to change the base?
DDUF documentation #1526
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Célina <hanouticelina@gmail.com>
Co-authored-by: Julien Chaumond <julien@huggingface.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Co-authored-by: Julien Chaumond <julien@huggingface.co>
Co-authored-by: vb <vaibhavs10@gmail.com>
Co-authored-by: vb <vaibhavs10@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! 👏
docs/hub/dduf.md
Outdated
|
||
## Overview | ||
|
||
DDUF (**D**DUF’s **D**iffusion **U**nified **F**ormat) is a file format designed to make storing, distributing, and using diffusion models much easier. Built on the ZIP file format, DDUF offers a standardized, efficient, and flexible way to package all parts of a diffusion model into a single, easy-to-manage file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diffusion Data Unified Format maybe? Also fine with it as is 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very very detailed! Steven has already taken care of most of the stuff. My comments are quite minor.
ZIP provides several advantages: | ||
- Universally supported file format | ||
- No additional dependencies for reading | ||
- Built-in file indexing | ||
- Wide language support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julien-c should there be any points pertaining to the connection between using ZIP and how that benefits Xet backend?
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Many thanks for the review! Very useful feedback ❤️ I've not addressed all the comments and added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to add a Who's using DDUF
section which will be one of the most important section of this doc (#community-driven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, there is a start at the very bottom of the page (could be moved to its own section)
Will merge this once huggingface_hub / diffusers have been released :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice docs ! LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets gooo
|
||
### Which frameworks/apps support DDUFs? | ||
|
||
- [Diffusers](https://github.com/huggingface/diffusers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we might have Eric's diffuse-rs
(candle-based) come in by monday too. So we'll have two supported frameworsk on day-0, but we can open a seperate pr for that
TODO:
https://moon-ci-docs.huggingface.co/docs/hub/pr_1526/en/dduf