Skip to content

Fix Types in Build #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coyotte508 merged 1 commit into from
Mar 27, 2024
Merged

Fix Types in Build #585

coyotte508 merged 1 commit into from
Mar 27, 2024

Conversation

@abdel-17
Copy link

@abdel-17 abdel-17 commented Mar 26, 2024

Fixes #584

coyotte508
coyotte508 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@coyotte508 coyotte508 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Ok for now, later let's try to do as in #584 (comment)

cc @SBrandeis

@coyotte508 coyotte508 merged commit 4f70dba into huggingface:main Mar 27, 2024
@abdel-17 abdel-17 deleted the fix-generated-types branch March 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

@vvmnnnkv vvmnnnkv Awaiting requested review from vvmnnnkv

@radames radames Awaiting requested review from radames

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Type From the Inference Package

2 participants

@abdel-17 @coyotte508