Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion.url is being wrong #1463

Closed
mishig25 opened this issue May 4, 2023 · 1 comment · Fixed by #1465
Closed

Discussion.url is being wrong #1463

mishig25 opened this issue May 4, 2023 · 1 comment · Fixed by #1465
Assignees
@Wauplin
Labels
bug Something isn't working

Comments

@mishig25
Copy link
Contributor

mishig25 commented May 4, 2023 •
edited
Loading 

discussion = create_discussion(
    repo_id="abc/xyz",
    title="Title",
    description="description"
    repo_type="space"
)

discussion.url is being hf.co/space/abc/xyz/discussions/{NUMBER}, missing "s", should be "spaces" not "space" after hf.co
@mishig25 mishig25 added the bug Something isn't working label May 4, 2023
@Wauplin Wauplin mentioned this issue May 8, 2023
Merged
@Wauplin
Copy link
Contributor

Wauplin commented May 8, 2023 •
edited
Loading

Thanks for reporting it @mishig25. Stupid mistake of mine 😬 I just made a PR for it if you can review it
#1465 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wauplin Wauplin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix discussion URL on datasets and spaces huggingface/huggingface_hub
2 participants
@Wauplin @mishig25